Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-- takes (incorrectly) takes precedence over allowing hyphen values #960

Closed
kbknapp opened this issue May 15, 2017 · 0 comments
Closed

-- takes (incorrectly) takes precedence over allowing hyphen values #960

kbknapp opened this issue May 15, 2017 · 0 comments
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies
Milestone

Comments

@kbknapp
Copy link
Member

kbknapp commented May 15, 2017

See BurntSushi/ripgrep#482

The error stems from src/app/parser.rs#803 which isn't considering if we're currently parsing a value or not and whether that value allows leading hyphens.

My only concern is args like ripgrep's -e which allow multiple values, is there a case where -e -- -- arg1 would be valid? Where the second -- is meant as the true "only positional args follow". (NB ripgrep specifically actually avoids this edge case by [correctly] only allowing one value per -e invocation.)

@kbknapp kbknapp added A-parsing Area: Parser's logic and needs it changed somehow. D: easy C-bug Category: Updating dependencies labels May 15, 2017
@kbknapp kbknapp added this to the 2.24.2 milestone May 15, 2017
kbknapp added a commit that referenced this issue May 15, 2017
…couldnt contain a double hyphen -- as a value

Closes #960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies
Projects
None yet
Development

No branches or pull requests

1 participant