-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Names of missing required arguments are always colorized #775
Comments
Is this with using |
It's not, but even with it, that one thing is still colored. |
OK, this is because the closure in |
Great catch! Yeah that would be an acceptable fix. I'm on mobile right now, so if you'd like to do the PR feel free 😉 |
Only colorize missing arguments when appropriate Instead of using Format::Error directly, we need to use a Colorizer to make sure that the message only gets colorized when it is appropriate to do so. Fixes #775
Only colorize missing arguments when appropriate Instead of using Format::Error directly, we need to use a Colorizer to make sure that the message only gets colorized when it is appropriate to do so. Fixes #775
Instead of using Format::Error directly, we need to use a Colorizer to make sure that the message only gets colorized when it is appropriate to do so. Fixes #775
Affected Version of clap
2.19.2
Expected Behavior Summary
Coloring is only applied when output is sent to a terminal.
Actual Behavior Summary
The name of the missing required argument is always colorized, giving messed up output e.g. capturing output into vim's quickfix buffer.
The text was updated successfully, but these errors were encountered: