Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After Help and Before Help Issues #516

Closed
4 tasks done
mitsuhiko opened this issue May 29, 2016 · 3 comments
Closed
4 tasks done

After Help and Before Help Issues #516

mitsuhiko opened this issue May 29, 2016 · 3 comments
Labels
A-help Area: documentation, including docs.rs, readme, examples, etc... C-bug Category: Updating dependencies

Comments

@mitsuhiko
Copy link
Contributor

mitsuhiko commented May 29, 2016 •
edited by kbknapp
Loading

Things I noticed

  • Currently before_help does not seem to do anything for subcommands
  • after_help does not render a leading newline
  • after_help is not wrapped at the terminal width
  • before_help is not wrapped at terminal width
@kbknapp
Copy link
Member

kbknapp commented May 30, 2016

Thanks for filing these! 👍

@kbknapp kbknapp added C-bug Category: Updating dependencies P2: need to have A-help Area: documentation, including docs.rs, readme, examples, etc... labels May 30, 2016
@kbknapp kbknapp mentioned this issue May 30, 2016
Merged
@kbknapp
Copy link
Member

kbknapp commented May 30, 2016

Numbers 1 and 2 should be fixed with #517 I'll do the third as I get time over this trip or as soon as I get home.

homu added a commit that referenced this issue May 31, 2016
@homu
Auto merge of #517 - kbknapp:quick-issues, r=kbknapp
ed0fd8a 
Quick issues

Relates to #515 #516 #514
homu added a commit that referenced this issue May 31, 2016
@homu
Auto merge of #517 - kbknapp:quick-issues, r=kbknapp
33412b7 
Quick issues

Relates to #515 #516 #514
homu added a commit that referenced this issue May 31, 2016
@homu
Auto merge of #517 - kbknapp:quick-issues, r=kbknapp
34e608c 
Quick issues

Relates to #515 #516 #514
@kbknapp
Copy link
Member

kbknapp commented Jun 14, 2016

This is fixed with #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-help Area: documentation, including docs.rs, readme, examples, etc... C-bug Category: Updating dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitsuhiko @kbknapp