Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List upcast converters should not remove invalid nodes. #16636

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Fix (list): Text nodes directly inside <ul> or <ol> should not be removed while loading editor data. Closes #16450.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@Witoso
Copy link
Member

Witoso commented Jun 28, 2024

Lost items AFAICS wrap in p, so we can quickly avoid data loss situation, and just have data change. @Reinmar do you have any comments/historical context. IMHO works well enough to merge.

Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes the content being preserved, but those incorrect pieces of HTML will split the surrounding lists (CKE4 would "auto-li" them).

Still, it's a simple change now while aligning perfectly to CKE4 might be much harder, so let's go for simplicity.

@niegowski niegowski merged commit 09b31af into master Jul 3, 2024
7 checks passed
@niegowski niegowski deleted the ck/16450 branch July 3, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKEditor5 rendering is stripping nested HTML content, providing data loss for user
5 participants