Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating unnecessary arrays to improve performance #17143

Closed
scofalik opened this issue Sep 24, 2024 · 0 comments · Fixed by #17144
Closed

Avoid creating unnecessary arrays to improve performance #17143

scofalik opened this issue Sep 24, 2024 · 0 comments · Fixed by #17144
Assignees
@scofalik
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 78 (v43...

Comments

@scofalik
Copy link
Contributor

📝 Provide a description of the improvement

As pointed out by @sunesimonsen in these PRs: #16913, #16909, #16917, #16918, some parts of our code create unnecessary arrays which may lead to performance degredation. We should review these places and apply the fixes.
@scofalik scofalik added the type:improvement This issue reports a possible enhancement of an existing feature. label Sep 24, 2024
@scofalik scofalik self-assigned this Sep 24, 2024
@scofalik scofalik mentioned this issue Sep 24, 2024
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 24, 2024
scofalik added a commit that referenced this issue Sep 24, 2024
@scofalik
Merge pull request #17144 from ckeditor/ck/performance-research
8a0dd4b 
Other (engine): Performance improvements. Avoided creating unnecessary arrays. Closes #17143.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 24, 2024
@CKEditorBot CKEditorBot added this to the iteration 78 milestone Sep 24, 2024
@CKEditorBot CKEditorBot mentioned this issue Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 78 (v43.2.0)
Development

Successfully merging a pull request may close this issue.

Performance improvements. Avoided creating unnecessary arrays ckeditor/ckeditor5
2 participants
@scofalik @CKEditorBot