Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding youtube shorts url regex for Media Embed #17090

Closed
jisoooh0202 opened this issue Sep 12, 2024 · 0 comments · Fixed by #17099
Closed

Adding youtube shorts url regex for Media Embed #17090

jisoooh0202 opened this issue Sep 12, 2024 · 0 comments · Fixed by #17099
Assignees
Labels
type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@jisoooh0202
Copy link

jisoooh0202 commented Sep 12, 2024

📝 Provide a description of the improvement

The normal youtube video and the shorts have same embed code format.
It would be good if it has youtube shorts url regex in default Media Embed provider within youtube.

How the feature works now and what you'd like to change?

I was trying to add extraProvider for youtube shorts, but keep failing on save and display the content.
If the youtube shorts url is in regex with youtube, it will solve without adding extraProvider.
Not sure this is the correct place to add or not, but here is where I found the default regex for youtube.

The normal video and the shorts have same embed code format.

`<iframe src="https://www.youtube.com/embed/${ id }${ time ? `?start=${ time }` : '' }" ` +

Here is a regex for youtube shorts.

/^(?:m\.)?youtube\.com\/shorts\/([\w-]+)(?:\?t=(\d+))?/
@jisoooh0202 jisoooh0202 added the type:improvement This issue reports a possible enhancement of an existing feature. label Sep 12, 2024
@Mati365 Mati365 self-assigned this Sep 16, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 16, 2024
Mati365 added a commit that referenced this issue Sep 17, 2024
Feature (media-embed): It's now possible to embed YouTube shorts. Closes #17090
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 17, 2024
@CKEditorBot CKEditorBot added this to the iteration 78 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants