Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention plugin breaks when some characters are used as markers #16818

Closed
scofalik opened this issue Jul 30, 2024 · 0 comments · Fixed by #16813
Closed

Mention plugin breaks when some characters are used as markers #16818

scofalik opened this issue Jul 30, 2024 · 0 comments · Fixed by #16813
Assignees
@scofalik
Labels
package:mention squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 76 (v43...

Comments

@scofalik
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Set up Mention plugin to use \ as marker character.
  2. It crashes the editor.
@scofalik scofalik added type:bug This issue reports a buggy (incorrect) behavior. package:mention squad:collaboration Issue to be handled by the Collaboration team. labels Jul 30, 2024
@scofalik scofalik self-assigned this Jul 30, 2024
@scofalik scofalik mentioned this issue Jul 30, 2024
Merged
scofalik added a commit that referenced this issue Jul 30, 2024
@scofalik
Merge pull request #16813 from ckeditor/cc/merge-fields-fixes
5221aca 
Fix (mention): Escape mentions markers when building regular expression to prevent crashes when markers like '\' are used. Closes #16818.

Internal (code-block): Disallow formatting attributes on nodes inside code block (instead of disallowing all attributes on text nodes). This is at the same time broader and more precise rule.
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jul 30, 2024
@CKEditorBot CKEditorBot mentioned this issue Jul 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:mention squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 76 (v43.0.0)
Development

Successfully merging a pull request may close this issue.

Fixes related to merge fields feature ckeditor/ckeditor5
2 participants
@scofalik @CKEditorBot