Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKBox init influences the starting time of the editor #16760

Closed
Mati365 opened this issue Jul 18, 2024 · 0 comments · Fixed by #16694
Closed

CKBox init influences the starting time of the editor #16760

Mati365 opened this issue Jul 18, 2024 · 0 comments · Fixed by #16694
Labels
type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Mati365
Copy link
Member

Mati365 commented Jul 18, 2024

📝 Provide detailed reproduction steps (if any)

CKBoxUtils#init method delays initialization of the editor until the token is loaded from backend. We can do that in the background and fetch token without waiting for backend response. At this moment it influences docs and builder.

✔️ Expected result

CKBoxUtils#init waits to fulfill token promise.

❌ Actual result

Token is fetched in the background.

@Mati365 Mati365 added type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature. labels Jul 18, 2024
Mati365 added a commit that referenced this issue Jul 23, 2024
Other (ckbox): The plugin no longer slows down the editor startup because it fetches the token in the background instead of during the editor’s initialization. Closes #16760

MINOR BREAKING CHANGE (ckbox): The `CKBoxUtils#getWorkspaceId` and `CKBoxUtils#getToken` methods now return a promise instead of a resolved value.
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants