Change global variable names #16736
Labels
resolution:resolved
This issue was already resolved (e.g. by another ticket).
squad:core
Issue to be handled by the Core team.
type:improvement
This issue reports a possible enhancement of an existing feature.
Comments
filipsobol
added
the
type:improvement
This was referenced Jul 16, 2024
pomek
added a commit
to ckeditor/ckeditor5-react
that referenced
this issue
Jul 17, 2024
Fix: Change the global name used in the UMD build from `CKEditor` to `CKEDITOR_REACT` to match the new convention. See ckeditor/ckeditor5#16736. MINOR BREAKING CHANGE: Change the global name used in the UMD build from `CKEditor` to `CKEDITOR_REACT`.
pomek
added a commit
to ckeditor/ckeditor5-vue
that referenced
this issue
Jul 17, 2024
Fix: Change the global name used in the UMD build from `CKEditor` to `CKEDITOR_VUE` to match the new convention. See ckeditor/ckeditor5#16736. MINOR BREAKING CHANGE: Change the global name used in the UMD build from `CKEditor` to `CKEDITOR_VUE`.
Witoso
added
squad:core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the release 42.0.0, alongside the ESM browser builds we also introduced UMD browser builds. The latter build was not mentioned in the changelog nor the documentation because we weren't ready to promote this installation methods yet (and they shouldn't be used yet).
After the discussion, we decided that we're not happy with the names of the global variables we used that match the names of the npm packages (
ckeditor5andckeditor5-premium-features) and instead we should use the following names:CKEDITOR_VUEckeditor5-vue#295CKEDITOR_REACTckeditor5-react#505The text was updated successfully, but these errors were encountered: