Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y best practice: Landmarks should be unique #16544

Closed
Joel-Levi opened this issue Jun 11, 2024 · 1 comment · Fixed by #16550
Closed

A11y best practice: Landmarks should be unique #16544

Joel-Levi opened this issue Jun 11, 2024 · 1 comment · Fixed by #16550
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Joel-Levi
Copy link

Following this pull request

There are now 2 aria live regions with role='region'
image

This violates the following best practice rule:

Rule: landmark-unique
Impact: moderate
Ensures landmarks are unique (https://dequeuniversity.com/rules/axe/4.8/landmark-unique?application=axeAPI))

The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable

While it is not strictly required, it is considered a best practice, I found out about it because I run chai a11y axe

  • Browser: All
  • OS: N/A
  • First affected CKEditor version: v41.4.0
  • Installed CKEditor plugins: ---

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Joel-Levi Joel-Levi added the type:bug This issue reports a buggy (incorrect) behavior. label Jun 11, 2024
@Witoso Witoso added the domain:accessibility This issue reports an accessibility problem. label Jun 11, 2024
@Mati365 Mati365 self-assigned this Jun 11, 2024
@aldonace-wu aldonace-wu added the support:2 An issue reported by a commercially licensed client. label Jun 11, 2024
@Mati365
Copy link
Member

Mati365 commented Jun 12, 2024

Hi @Joel-Levi!

Thanks for report. Indeed, the role=region attribute should not be set there, so your tests were correct. We discussed it, and we'll remove this attribute in this PR.

Let's know in case of any further issues.

DawidKossowski added a commit that referenced this issue Jun 13, 2024
Fix (UI): The aria-live views will no longer violate the a11y aXe rule: `landmarks should be unique`. Closes #16544.
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants