Skip to content

Commit

Permalink
Merge pull request #16751 from ckeditor/fix-exports-in-ckeditor5
Browse files Browse the repository at this point in the history
Fix (ckeditor5): Update the `exports` field in `package.json` to fix issues with loading CSS and translations in older bundlers. See #16638.

Internal: Remove the "Lint generated packages" step from CI due to a limitation of the validation library.
  • Loading branch information
filipsobol authored Jul 22, 2024
2 parents d02cf59 + 8469763 commit 8466080
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
10 changes: 6 additions & 4 deletions .circleci/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,12 @@ jobs:
name: Check if packages are ready to be released
command:
yarn run release:prepare-packages --compile-only --verbose
- run:
name: Lint generated packages
command:
yarn run release:lint-packages

# Commented out due to a limitation of publint: https://github.com/bluwy/publint/issues/105
# - run:
# name: Lint generated packages
# command:
# yarn run release:lint-packages

notify_ci_failure:
machine: true
Expand Down
7 changes: 2 additions & 5 deletions scripts/release/utils/getckeditor5packagejson.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,8 @@ module.exports = function getCKEditor5PackageJson() {
'types': './dist/types/index.d.ts',
'import': './dist/ckeditor5.js'
},
'./translations/*.js': {
'types': './dist/translations/*.d.ts',
'import': './dist/translations/*.js'
},
'./*.css': './dist/*.css',
'./*': './dist/*',
'./browser/*': null,
'./build/*': './build/*',
'./src/*': './src/*',
'./package.json': './package.json'
Expand Down

0 comments on commit 8466080

Please sign in to comment.