Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Packet Correlation ID #30

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Add Packet Correlation ID #30

merged 4 commits into from
Sep 5, 2024

Conversation

piercema
Copy link
Contributor

🗣 Description

A correlation ID is added to tie log lines from the same packet together and provide a finer-grained association than the connection ID.

💭 Motivation and context

This was requested by a partner organization stating: "ENIP header is separated from the CIP header with no identification field between them that indicates they came from the same packet"

🧪 Testing

Btests were updated and run smoothly. I also examined the individual log files to ensure the ID's appeared correct

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Contributor

@kkvarfordt kkvarfordt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checked code changes, verified installation via zkg, and ran a packet capture through the parser to verify the id's are generated and correctly link log files together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants