GHA cache: handle io.EOF when uploading a part #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And pass-through other errors that Actions Toolkit deems as retryable.
fkorotkov
reviewed
Sep 19, 2024
Comment on lines
231
to
242
| status := http.StatusInternalServerError | ||
|
|
||
| // Cause the cache-related code in the Actions Toolkit to make a re-try[1]. | ||
| // | ||
| // [1]: https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/cache/src/internal/requestUtils.ts#L24-L34 | ||
| if uploadPartResponse.StatusCode == http.StatusBadGateway || | ||
| uploadPartResponse.StatusCode == http.StatusServiceUnavailable || | ||
| uploadPartResponse.StatusCode == http.StatusGatewayTimeout { | ||
| status = uploadPartResponse.StatusCode | ||
| } | ||
|
|
||
| fail(writer, request, status, "GHA cache failed to upload part "+ |
There was a problem hiding this comment.
Maybe just propagate the response code?
Suggested change
| status := http.StatusInternalServerError | |
| // Cause the cache-related code in the Actions Toolkit to make a re-try[1]. | |
| // | |
| // [1]: https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/cache/src/internal/requestUtils.ts#L24-L34 | |
| if uploadPartResponse.StatusCode == http.StatusBadGateway || | |
| uploadPartResponse.StatusCode == http.StatusServiceUnavailable || | |
| uploadPartResponse.StatusCode == http.StatusGatewayTimeout { | |
| status = uploadPartResponse.StatusCode | |
| } | |
| fail(writer, request, status, "GHA cache failed to upload part "+ | |
| fail(writer, request, uploadPartResponse.StatusCode, "GHA cache failed to upload part "+ |
There was a problem hiding this comment.
Maybe just log it to Sentry? To avoid leaking the abstraction details too early.
There was a problem hiding this comment.
I don't see a problem of leaking an abstraction here. Only the status code will be "leaked".
There was a problem hiding this comment.
OK, implemented in a467d01.
Comment on lines
215
to
224
| status := http.StatusInternalServerError | ||
|
|
||
| // Cause the cache-related code in the Actions Toolkit to make a re-try[1]. | ||
| // | ||
| // [1]: https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/cache/src/internal/requestUtils.ts#L24-L34 | ||
| if errors.Is(err, io.EOF) { | ||
| status = http.StatusBadGateway | ||
| } | ||
|
|
||
| fail(writer, request, status, "GHA cache failed to upload part "+ |
There was a problem hiding this comment.
Maybe always return 503?
Suggested change
| status := http.StatusInternalServerError | |
| // Cause the cache-related code in the Actions Toolkit to make a re-try[1]. | |
| // | |
| // [1]: https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/cache/src/internal/requestUtils.ts#L24-L34 | |
| if errors.Is(err, io.EOF) { | |
| status = http.StatusBadGateway | |
| } | |
| fail(writer, request, status, "GHA cache failed to upload part "+ | |
| fail(writer, request, http.StatusServiceUnavailable, "GHA cache failed to upload part "+ |
There was a problem hiding this comment.
See #789 (comment).
There was a problem hiding this comment.
Now this always returns HTTP 502, which seems to be more generic than HTTP 503, which is important since we don't differentiate between different errors at all with this approach.
Let me know if you specifically want HTTP 503.
fkorotkov
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And pass-through other errors that Actions Toolkit deems as retryable.