Fix tracking skb #410
Merged
Fix tracking skb #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilium#339 changed how pwru tracks skb from using &skb to skb->head for xdp tracing. We found it causing problems such as: 1. An skb can have multiple different skb->head values during its lifetime, especically after (e.g. IPsec) encryption. Pwru now is likely to lose track of skb after encryption. 2. Some subtle issues like cilium#401. This is because some other tracking mechanism relies on &skb. This commit brings back tracking &skb instead of skb->head. As for XDP tracing, I'll introduce a new solution in the following patches. Signed-off-by: gray <gray.liang@isovalent.com>
This commit records xdp->data_hard_start at fexit/xdp. The skb built from xdp_md will have the same value of skb->head. Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
|
Requesting an additional review from @brb since I'm not that familiar with the BPF bits of pwru. |
tklauser
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses &skb to track skb instead of skb->head to prevent several issues. XDP tracing is also taken care of by introducing a new bpf map
xdp_dhs_skb_heads.