link: document AttachCgroup and flags #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgo3
approved these changes
Mar 21, 2023
Yep, we had to find that out the hard way. 😢 |
lmb
requested changes
Mar 22, 2023
Ooh! Now I understand why you changed the doc. |
ti-mo
force-pushed
the
tb/attach-cgroup-flags
branch
from
6d67c99
to
c13bf99
Compare
lmb
reviewed
Mar 22, 2023
…achCgroup Prog only needs to be cloned in newProgAttachCgroup. Remove the Close() footgun, making future modifications less tricky. Execute PROG_ATTACH using the cloned program for good measure. Signed-off-by: Timo Beckers <timo@isovalent.com>
Also addressed an inaccuracy in the QueryPrograms docstring. bpf_link progs are returned through PROG_QUERY. Clarify that BPF_F_REPLACE only affects programs attached with the Multi flag. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/attach-cgroup-flags
branch
from
c13bf99
to
fa35bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document some of the lessons learned through cilium/cilium#23557.
Also removes some papercuts from
AttachCgroupresource cloning.