link: make KprobeMultiOptions.Addresses a []uintptr #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel expects kprobe_multi.addrs to point at an array of unsigned long. The size of unsigned long is compiler or platform dependent, so using uint64 is incorrect on 32-bit arches. uintptr seems like the closest analog to C's unsigned long, although I've not been able to figure out how uintptr is really defined. See https://elixir.bootlin.com/linux/v6.1.7/source/kernel/trace/bpf_trace.c#L2671 Signed-off-by: Lorenz Bauer <oss@lmb.io>
mmat11
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel expects kprobe_multi.addrs to point at an array of unsigned long. The size of unsigned long is compiler or platform dependent, so using uint64 is incorrect on 32-bit arches.
uintptr seems like the closest analog to C's unsigned long, although I've not been able to figure out how uintptr is really defined.
See https://elixir.bootlin.com/linux/v6.1.7/source/kernel/trace/bpf_trace.c#L2671
Signed-off-by: Lorenz Bauer oss@lmb.io