Remove deprecated +build Go build tags
#888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
force-pushed
the
tb/new-go-build-tags
branch
from
f3b0f67
to
e994bf4
Compare
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
To follow suit with the new //go:build convention of build tags, this commit converts bpf2go to no longer emit the deprecated +build lines. The bpf2go command line interface remains unchanged to avoid breaking users. In the future we can introduce a new -constraints flag and deprecate -tags. Signed-off-by: Timo Beckers <timo@isovalent.com> Co-developed-by: Lorenz Bauer <oss@lmb.io>
lmb
force-pushed
the
tb/new-go-build-tags
branch
from
43ba79b
to
5c74f09
Compare
lmb
reviewed
Jan 16, 2023
| @@ -14,4 +14,6 @@ KeepEmptyLinesAtTheStartOfBlocks: false | |||
| TabWidth: 4 | |||
| UseTab: ForContinuationAndIndentation | |||
| ColumnLimit: 1000 | |||
| # Go compiler comments need to stay unindented. | |||
| CommentPragmas: '^go:.*' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin, remove
+buildin favour of//go:build. To keep this straightforward, it uses a[][]stringinternally, and the template engine ORs all inner slices and ANDs all outer slices. This causes a clean diff with everything currently in examples/.There's one problem: specifying multiple exclusions is currently a bit broken.
-tags "!foo !bar"will result in//go:build (!foo || !bar), which cancels each other out. We could pick out all tags starting with!and render them out to a separate clause that's ANDed?@lmb let me know what you think.