Provide 15-byte context inputs to Program.{Run,Benchmark,Test}
#792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
reviewed
Sep 14, 2022
lmb
approved these changes
Sep 14, 2022
ti-mo
force-pushed
the
tb/14-byte-bpf-context
branch
from
e78bdca
to
6624eb1
Compare
…ontexts After a38fb6b, now centralize the allocation of a 15-byte buffer for PROG_TEST_RUN using a once-allocated var in internal/. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/14-byte-bpf-context
branch
from
6624eb1
to
c3ab0b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize allocation of the buffer to avoid some duplication and ease future changes to the minimum buffer size.
The patch that introduced this regression doesn't officially land until 6.0, but it has already been backported to kernels as early as 5.15.65 (potentially even earlier?).
cc @dylandreimerink