Avoid leaking fds in test suite and NewMapWithOptions()
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ti-mo
commented
Jul 1, 2022
ti-mo
commented
If a Map fails to be populated or frozen during creation, we would leak a fd for the runtime to collect. This patch ensures the fd is closed before returning from NewMapWithOptions. Signed-off-by: Timo Beckers <timo@isovalent.com>
Since omitting Map and Program.Close() is generally considered an error, clean up all cases in the test suite. These were found by adding runtime.GC() at the end of a TestMain() in all packages in the repository. The plan is to follow up with some instrumentation that allows the caller to get notified when the sys.FD finalizer successfully closes a file descriptor during a GC round. Signed-off-by: Timo Beckers <timo@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.