Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mention inexistent outLen parameter in (*Program).Test godoc #1426

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

tklauser
Copy link
Member

The outLen parameter to (*Program).Test was removed in commit e45ae4a ("detect kernel support for BPF_PROG_TEST_RUN and work around unsafe API"). Remove it from the godoc comment as well.

@tklauser tklauser requested a review from a team as a code owner April 10, 2024 09:52
Copy link
Collaborator

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser tklauser changed the title Don't mention inexistend outLen Parameter in (*Program).Test godoc Don't mention inexistent outLen Parameter in (*Program).Test godoc Apr 10, 2024
The outLen parameter to (*Program).Test was removed in commit
e45ae4a ("detect kernel support for BPF_PROG_TEST_RUN and work
around unsafe API"). Remove it from the godoc comment as well.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser changed the title Don't mention inexistent outLen Parameter in (*Program).Test godoc Don't mention inexistent outLen parameter in (*Program).Test godoc Apr 10, 2024
@lmb lmb merged commit c6e8fb6 into cilium:main Apr 10, 2024
5 checks passed
@tklauser tklauser deleted the prog-test-outlen-godoc branch April 10, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants