btf: synthesise instruction comments into line info #1417
Conversation
When an asm.Comment is added to an instruction, existing source information like btf.Line will be replaced. But in some cases, instructions without line information won't pass the verifier. The expected behavior would be, that the comment gets synthesized into a line info where everything but the line string is zero. This commit implements this. Fixes cilium#1413 Signed-off-by: Marcus Wichelmann <mail@marcusw.de>
Signed-off-by: Marcus Wichelmann <mail@marcusw.de>
MarcusWichelmann
force-pushed
the
asm-comment-to-line-info
branch
from
8edd81a
to
3ccdc4f
Compare
|
I'm not sure why the
|
|
Yea, its a bit odd. It almost looks like the test runner gets stuck, perhaps a struck test. It seems flaky, we had the same on the initial push, which was resolved after a retry. Unfortunately the CI action gets killed before the test framework itself, so we don't get any info about which test might be stuck. The default go timeout is 10m as well, so I will see if we can extend the runner timeout to something like 15m so that the go tests can exit on its own accord on a stuck test and give us some clue about its source. |
|
I am fairly certain its #1419 since I ran into it while making the PR to up the timeout, so don't worry about it. |
When an asm.Comment is added to an instruction, existing source information like btf.Line will be replaced. But in some cases, instructions without line information won't pass the verifier. The expected behavior would be, that the comment gets synthesized into a line info where everything but the line string is zero. This PR implements this.
Fixes #1413