btf: Optimize string table for globally increasing offsets #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
requested changes
Nov 7, 2023
dylandreimerink
force-pushed
the
feature/btf-string-incr-fastpath
branch
2 times, most recently
from
cbc466b
to
406033c
Compare
After doing some observations while parsing VMLinux, it seems that the
lookup access pattern for strings is mostly globally increasing with
with some patches of seemingly unpridicable offsets.
This is a sample of the access pattern, numbers are the index into the
string table, not the offset:
```
1112
1113
1114
348
78
1115
1116
372
1117
1118
1119
```
This commit adds logic to track this globally increasing offset and
checks if the if the offset at the next expected index matches the
offset we are looking for. If it does, we can skip the binary search.
In VMLinux this fast path is taken about 50% of the time, resulting in
about a 7% speedup.
```
goos: linux
goarch: amd64
pkg: github.com/cilium/ebpf/btf
cpu: 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
│ before.txt │ after.txt │
│ sec/op │ sec/op vs base │
ParseVmlinux-16 48.52m ± 1% 44.79m ± 1% -7.69% (n=100)
│ before.txt │ after.txt │
│ B/op │ B/op vs base │
ParseVmlinux-16 31.45Mi ± 0% 31.45Mi ± 0% ~ (p=0.127 n=100)
│ before.txt │ after.txt │
│ allocs/op │ allocs/op vs base │
ParseVmlinux-16 534.1k ± 0% 534.1k ± 0% ~ (p=0.130 n=100)
```
Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/btf-string-incr-fastpath
branch
from
406033c
to
fd47833
Compare
|
I get this on my machine: The laptop is plugged in and I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some observations while parsing VMLinux, it seems that the lookup access pattern for strings is mostly globally increasing with with some patches of seemingly unpridicable offsets.
This is a sample of the access pattern, numbers are the index into the string table, not the offset:
This commit adds logic to track this globally increasing offset and checks if the if the offset at the next expected index matches the offset we are looking for. If it does, we can skip the binary search. In VMLinux this fast path is taken about 50% of the time, resulting in about a 7% speedup.