Bundle code into a single file without dependencies #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghengeveld I think it's ready for review! |
ndelangen
commented
Aug 26, 2021
ndelangen
added
dependencies
OzzieOrca
added a commit
to CruGlobal/mpdx-react
that referenced
this pull request
Aug 31, 2021
ghengeveld
changed the title
|
I'm, testing this across a few repositories.. |
|
looking good now: |
ndelangen
force-pushed
the
tech/bundling
branch
3 times, most recently
from
68c1672
to
e11522d
Compare
ndelangen
force-pushed
the
tech/bundling
branch
from
e11522d
to
1078e57
Compare
|
I took out the breaking change, so it should be backwards compatible, I tested this on the chromatic repo |
… and get that data to get viewLayer and addons.
tech/add-test-workflow_run
Ask yarn for packages instead of trying to resolve them
OzzieOrca
added a commit
to CruGlobal/mpdx-react
that referenced
this pull request
Oct 1, 2021
- chromaui/chromatic-cli#393 was merged and released, adding support for Yarn v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more dependencies need to be installed!
This should increase
by asking the yarn cli for storybook packages,
instead of trying to resolve them all.
(use the resolving mechanism is asking the yarn cli fails)
This fixes: #166
workflow_runfor our actionThis fixes: #396