[ENH] updates & invalid operations should also trigger persisting of local HNSW #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
commented
Jul 10, 2024
HammadB
reviewed
Jul 11, 2024
codetheweb
changed the title
codetheweb
commented
Jul 11, 2024
codetheweb
commented
Jul 11, 2024
codetheweb
commented
Jul 12, 2024
| with_persistent_hnsw_params=True, | ||
| # By default, these are set to 2000, which makes it unlikely that index mutations will ever be fully flushed | ||
| max_hnsw_sync_threshold=10, | ||
| max_hnsw_batch_size=10, |
There was a problem hiding this comment.
without reducing the sync threshold, this test will almost never fully flush to disk, which makes the correctness guarantee weaker
without this change, the pickled metadata file was never loaded
codetheweb
commented
Jul 12, 2024
| @@ -336,6 +344,10 @@ def test_cycle_versions( | |||
| name=collection_strategy.name, | |||
| embedding_function=not_implemented_ef(), # type: ignore | |||
| ) | |||
|
|
|||
| # Should be able to add embeddings | |||
| coll.add(**embeddings_strategy) # type: ignore | |||
There was a problem hiding this comment.
causes the pickled metadata file to be loaded, a good thing to test since the class def changed and it needs special handling
codetheweb
changed the title
codetheweb
changed the base branch from
main
to
fix-persistent-hnsw-config-migration
codetheweb
force-pushed
the
fix-upsert-persist
branch
from
9126437
to
b8268b7
Compare
HammadB
approved these changes
Jul 15, 2024
codetheweb
added a commit
that referenced
this pull request
Jul 15, 2024
Didn't catch after a refactor in #2499. This is not a correctness bug, this would have resulted in a persist/flush after every mutation if enough invalid operations had accumulated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benefits aren't immediately clear in this PR, but this allows future work to correctly track the maximum sequence ID.
Depends on #2511.