-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Resiliency for local observability #1931
base: main
Are you sure you want to change the base?
[ENH]: Resiliency for local observability #1931
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? have users asked for it?
@beggers, I was supporting a user where we had to do some tracing but for Zipkin kept crashing so we had to do this change. So decided to contribute it back to our local observatory. It is not strictly needed, but for tracing non-trivial use cases it is really helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems quite reasonable. Just a small request for documentation :^)
88afaf5
to
2333793
Compare
2333793
to
61e9f59
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Manual test
Documentation Changes
N/A