-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a checkbox to transmit location information or not. #48
base: master
Are you sure you want to change the base?
Added a checkbox to transmit location information or not. #48
Conversation
…le to not transmit any data at all, temp - incase of doing things in the wild, etc.
@@ -89,14 +89,16 @@ public void submitToApi() { | |||
|
|||
Map<String, Object> updates = new HashMap<>(); | |||
updates.put("name", playerName); | |||
if (locationOption()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am looking to accept this, but I want to also send the option selection to the api so it can disable sending the data from there. I would also like to indicate on the website that a player has disabled this. I will try to add this in a few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christoabrown Have you been able to add this to the API? <3
return true; | ||
} | ||
|
||
@ConfigItem( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this makes sense to have since all the plugin does is send data so a user could disable it in runelite to get the same effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The in-game activity one makes sense for this, as disabling the in-game activity option is essentially disabling the plugin without disabling it. However, the disable location, just prevents your team from seeing your location but allows for everything else to appear.
…e activity transmission to advise that it also includes location.
…No different than just disabling your plugin as a whole. However, left location as disabling location while keeping the app active is helpful in a lot of ways.
Created ability to prevent the location information from being sent over to the backend.