Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof P76 (#239) #317

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Proof P76 (#239) #317

merged 3 commits into from
Mar 23, 2018

Conversation

keller0
Copy link
Contributor

@keller0 keller0 commented Mar 12, 2018

Proof P76 #239

@wopian wopian added Status: Review Needed Type: Proof Comanche55 and Luminary99 files labels Mar 20, 2018
@wopian wopian added this to the Comanche055 milestone Mar 20, 2018
@@ -35,10 +35,10 @@
# TIME (TIG) AT WHICH THE OTHER VEHICLE VELOCITY WAS CHANGED BY EXECUTION OF A THRUSTING MANEUVER. THE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- instead of - on lines 32 and 33

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -35,10 +35,10 @@
# TIME (TIG) AT WHICH THE OTHER VEHICLE VELOCITY WAS CHANGED BY EXECUTION OF A THRUSTING MANEUVER. THE
# OTHER VEHICLE STATE VECTOR IS INTEGRATED TO TIG AND UPDATED BY THE ADDITION OF DELTA V (DELTA V HAVING
# BEEN TRANSFORMED FROM LV TO REF COSYS). USING INTEGRVS, THE PROGRAM THEN INTEGRATES THE OTHER
# VEHICLE STATE VECTOR TO THE STATE VECTOR OF THIS VEHICLE, THUS INSURING THAT THE W-MATRIX AND BOTH VEHICLE
# VEHICLE STATE VECTOR TO THE STATE VECTOR OF THIS VEHICLE. THUS INSURING THAT THE W-MATRIX AND BOTH VEHICLE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ This is yet another badly printed comma - you can partially see the flick through the jpeg artefacts

# STATES CORRESPOND TO THE SAME TIME.
# 3) ERASABLE INITIALIZATION REQUIRED -- NONE.
# 4) CALLING SEQUENCES AND EXIT MODES -- CALLED BY ASTRONAUT REQUEST THRU DSKY V 37 E 76E.
# 4) CALLING SEQUENCES AND EXIT MODES -- CALLED BY ASTRONAUT REQUEST THRU DSKY V 37 E 76 E.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- to - for all the lines around this

# STATES CORRESPOND TO THE SAME TIME.
# 3) ERASABLE INITIALIZATION REQUIRED -- NONE.
# 4) CALLING SEQUENCES AND EXIT MODES -- CALLED BY ASTRONAUT REQUEST THRU DSKY V 37 E 76E.
# 4) CALLING SEQUENCES AND EXIT MODES -- CALLED BY ASTRONAUT REQUEST THRU DSKY V 37 E 76 E.
# EXITS BY TCF ENDOFJOB.
# 5) OUTPUT -- OTHER VEHICLE STATE VECTOR INTEGRATED TO TIG AND INCREMENTED BY DELTA V IN REF COSYS.
# THE PUSHLIST CONTAINS THE MATRIX BY WHICH THE INPUT DELTA V MUST BE POST-MULTIPLIED TO CONVERT FROM LV
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For line # 7)...

✨ No spacing between list of BANKCALL to CSMPREC
✨ No spacing at LEMPREC),ATOPCSM
✨ No spacing between list of ATOPLEM) to INTWAKE

For line # 8)...

✨ No spacing between list of MOONFLAG to RASFLAG

2) -- to -
3) remove space after comma
@wopian
Copy link
Collaborator

wopian commented Mar 23, 2018

Thanks for this PR 🎉

@wopian wopian merged commit d04fea4 into chrislgarry:master Mar 23, 2018
@keller0 keller0 deleted the proofs branch March 23, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants