Skip to content
This repository has been archived by the owner on Oct 6, 2018. It is now read-only.

Commit

Permalink
Updates after Kate's code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Pearce committed Apr 5, 2015
1 parent 5602d81 commit bb4f03c
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 15 deletions.
2 changes: 1 addition & 1 deletion objects/_o-link-disguised.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* Make a link not look like a link.
*
* @markup
<a href="#" class="o-link-disguided">Some link text</a>
<a href="#" class="o-link-disguised">Some link text</a>
*/


Expand Down
2 changes: 1 addition & 1 deletion objects/_o-list-block.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* vertical list of links.
*
* @markup
<ul class="o-arrow [modifier]">
<ul class="o-list-block [modifier]">
<li>
<a href="#">Some link text</a>
</li>
Expand Down
2 changes: 1 addition & 1 deletion objects/_o-table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ $o-table-striped-background-cell-colour: $o-table-border-colour !d


/**
* Modifier: layout fixed, force tables into having equal-width column.
* Modifier: layout fixed, force tables into having equal-width columns.
*/

%o-table--fixed,
Expand Down
27 changes: 15 additions & 12 deletions utilities/_u-spacing.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@
* 6. Spacing remove: this is explicit
* 7. Spacing amount: this is explicit
*
* As they're so many spacing utilities the format for applying them at different
* breakpoints in your master stylesheet is a little different to the
* standard format. In addition to listing your breakpoints we have to list out
* the exact spacing utility classes we want those breakpoints applied to. So
* say we wanted to apply 3 `margin-bottom` spacing utilities at the 'Small',
* 'Base', and 'Large' sizing categories which are applied to the 'Palm' and 'Lap'
* breakpoints plus at a breakpoint of '886', we would do it like this:
*
$u-spacing-apply-at-breakpoints: (palm, lap, 886);
$u-spacing-apply-classes-for-breakpoints: (
".u-s-mb-small",
".u-s-mb-base",
".u-s-mb-large"
);
*
* All the utilities (available as silent placeholder selectors also):
*
// Base
Expand Down Expand Up @@ -251,18 +266,6 @@
.u-s-me-none
.u-s-pe-none
*
* As they're so many spacing utilities the format for applying them at different
* breakpoints in your master stylesheet is a little different to the
* standard format. In addition to listing your breakpoints we have to list out
* the exact spacing utilities we want those breakpoints applied to e.g.
*
$u-spacing-apply-at-breakpoints: (palm, lap, 886);
$u-spacing-apply-classes-for-breakpoints: (
".u-s-mb-small",
".u-s-mb-base",
".u-s-mt-base"
);
*
* @credit
* https://github.com/stubbornella/oocss/blob/master/oocss/src/components/whitespace/_whitespace.scss
*/
Expand Down

1 comment on commit bb4f03c

@kllevin
Copy link
Collaborator

@kllevin kllevin commented on bb4f03c Apr 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Please sign in to comment.