Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(option): optional target when router is used #512

Merged
merged 1 commit into from
Apr 1, 2021
Merged

fix(option): optional target when router is used #512

merged 1 commit into from
Apr 1, 2021

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Apr 1, 2021 •
edited
Loading

fixes #448
fixes #416

@chimurai chimurai force-pushed the optional-target branch 2 times, most recently from dd33f3b to 372c67a Compare April 1, 2021 22:23
@coveralls
Copy link

coveralls commented Apr 1, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 87.46% when pulling a0f84a7 on optional-target into de31475 on master.

@chimurai chimurai changed the title fix(target): optional target when router is used fix(option): optional target when router is used Apr 1, 2021
@chimurai chimurai merged commit 1515ba3 into master Apr 1, 2021
@chimurai chimurai deleted the optional-target branch April 1, 2021 22:57
@chimurai chimurai mentioned this pull request Apr 6, 2021
Merged
@dtoch dtoch mentioned this pull request Apr 12, 2021
Closed
@chimurai chimurai mentioned this pull request Apr 25, 2021
Closed
@lukasgeiter lukasgeiter mentioned this pull request Jun 28, 2021
Closed
2 tasks
@ihorbond ihorbond mentioned this pull request Aug 30, 2021
Open
@punehim punehim mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chimurai @coveralls