Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to specify CIDR blocks to allow for ingress #82

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add option to specify CIDR blocks to allow for ingress #82

merged 2 commits into from
Oct 26, 2023

Conversation

pv93
Copy link
Contributor

@pv93 pv93 commented Oct 19, 2023

No description provided.

@pv93 pv93 requested review from a team as code owners October 19, 2023 20:32
bwhaley
bwhaley requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@bwhaley bwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review - not sure how I missed this PR.

Thanks for the improvement! Just one fix and we should be able to merge this.

modules/terraform-aws-alternat/main.tf Outdated Show resolved Hide resolved
@pv93 @bwhaley
Update modules/terraform-aws-alternat/main.tf
7d74bcf 
Co-authored-by: Ben Whaley <bwhaley@gmail.com>
@pv93
Copy link
Contributor Author

pv93 commented Oct 26, 2023

Apologies for the delayed review - not sure how I missed this PR.

Thanks for the improvement! Just one fix and we should be able to merge this.

No worries, thanks for the review @bwhaley. I've committed your suggestion 👍

@bwhaley bwhaley merged commit e6fc58c into chime:main Oct 26, 2023
@pv93 pv93 deleted the security-group-cidr-range-ingress-var branch December 7, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwhaley bwhaley bwhaley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pv93 @bwhaley