Make Posix instances conditional for non-standard platforms #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, we've just run into this, as well. Can we get this merged? |
konsumlamm
reviewed
Nov 30, 2023
There was a problem hiding this comment.
I just ran into this as well, @chessai could this be merged?
| @@ -141,10 +141,51 @@ import qualified Prelude as P | |||
| #endif | |||
|
|
|||
| #if !HOST_OS_WINDOWS | |||
This was referenced Nov 30, 2023
|
Thanks for merging this! Any chance you can upload a new release with this change to Hackage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this note in the
System.Posix.TypesHaddocks:This e.g. fixes compilation via the new WASM backend in 9.6. I didn't adapt the TH-based boilerplate for pre-
DerivingViaGHCs (< 8.6) because I don't see a use case, but happy to also add the necessary CPP there if that is desired.A simpler alternative to this PR would be to drop these instances; this would be a breaking change, but I would be very surprised if anyone is actually using them.