Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove perl during cleanup process #714

Closed
wants to merge 1 commit into from

Conversation

jtreminio
Copy link

@jtreminio jtreminio commented Nov 8, 2016

Perl is required for installing/compiling and running too many programs to make it worth removing - users will simply need to install it back.

@rickard-von-essen
Copy link
Collaborator

I somewhat disagree, packages not strictly needed by Vagrant or which are not part of minimal installation shouldn't be included. The are easy enough to install. You can run allot of things on Linux without perl.

@cheeseplus
Copy link
Contributor

cheeseplus commented Nov 8, 2016

Thing is perl is almost always part of a base install and a variety of packages, probably incorrectly, depend on it being there. It doesn't add enough weight that I'm concerned about it. I think the expectation that it be there on most Linuxes is prevalent so even if I'm not keen on perl it's a reasonable assumption from the average user.

I mean if it blows up the images sizes by 100MB or something I can see wanting to avoid it but also if people are just installing it every time anyway we can save them a few steps.

@rickard-von-essen
Copy link
Collaborator

and a variety of packages, probably incorrectly, depend on it being there.

If that is the case I think there is a reason to keep it in the box, but to do it just because you don't want have to install it shouldn't be enough.

@jtreminio
Copy link
Author

@rickard-von-essen sorry, yes, I may has misworded it. Perl is required by enough packages in a vanilla OS that it makes sense to keep it around.

@cheeseplus
Copy link
Contributor

Totally, in this case it's more - system stuff will unexpectedly break. The impression when it was first added was that it was only needed for build-tools which after chatting with @jtreminio in IRC seems to not be the case.

@cheeseplus
Copy link
Contributor

Also I'll probably close this PR and open a new one so we don't have to have @jtreminio jump through the DCO hoop but I'll keep it open until then.

cheeseplus pushed a commit that referenced this pull request Nov 30, 2016
Signed-off-by: Seth Thomas <sthomas@chef.io>
@cheeseplus
Copy link
Contributor

Closing for #731

@cheeseplus cheeseplus closed this Nov 30, 2016
tas50 added a commit that referenced this pull request Nov 30, 2016
Provisionally keeping Perl. Redux of #714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants