fix or suppress all shellcheck warnings #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change-set represent the minimum possible change to either fix or suppress all warnings from the shellcheck linter. The presence of these warnings is an annoyance for those with automatic linting enabled in their editor of choice. This include dead variable removal but no logic or stylistic improvements.
|
I've got no objections here, love it +1 |
cheeseplus
pushed a commit
that referenced
this pull request
Dec 19, 2015
fix or suppress all shellcheck warnings
|
@cheeseplus Great! What do you think about adding shellcheck to travis? The downside to this is that the package has vanished from the travis apt mirrors and sudo has to be enabled to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change-set represent the minimum possible change to either fix or
suppress all warnings from the shellcheck linter. The presence of these
warnings is an annoyance for those with automatic linting enabled in
their editor of choice.
This include dead variable removal but no logic or stylistic
improvements.