Initial windows support #1053
Merged
Initial windows support #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been hacked up a bit from Matt's initial work. I'm going to continue to hack it up to meet our needs Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
cheeseplus
approved these changes
Jun 4, 2018
There was a problem hiding this comment.
Long overdue and great work brining this all together @tas50
|
Are the Bento builds forthcoming on Thanks a lot for doing this! We were actually planning to start building some ourselves as most of the others out there are pretty out of date. |
|
No, Windows builds right now are hosted by @tas50 while we figure out the build pipelines and make sure there aren't any issues legally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work done in Matt Wrock's https://github.com/mwrock/packer-templates. It's been modified to use Chef for almost all the work (minus final cleanup) and most of the things we did in boxcutter-windows have been moved over to the Chef recipe. Using Chef here is really nice not only because the complexity of the powershell/vbscript/batch melts away, but because we can easily test the logic in test kitchen without having to fully spin up a windows install. The feedback loop is pretty great, and after spending days waiting for boxcutter-windows installs to fail I'd never go back.
Signed-off-by: Tim Smith tsmith@chef.io