Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove node module caching dependency #1691

Merged
merged 2 commits into from
Jan 25, 2021
Merged

remove node module caching dependency #1691

merged 2 commits into from
Jan 25, 2021

Conversation

5saviahv
Copy link
Contributor

  • move .load() function own file so api methods could access other static functions early.
  • load load.js file after cheerio object is built.

should solve #1311 & #1689

it passes rollup test

fb55
fb55 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@fb55 fb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One outdated comment, otherwise this looks good!

index.js Outdated Show resolved Hide resolved
@5saviahv @fb55
Update index.js
d1e65eb 
Co-authored-by: Felix Böhm <me@feedic.com>
@fb55 fb55 merged commit a9d6a43 into cheeriojs:main Jan 25, 2021
@fb55 fb55 mentioned this pull request Jan 25, 2021
Closed
@5saviahv 5saviahv deleted the split-load branch January 25, 2021 13:24
@Omrisnyk Omrisnyk mentioned this pull request Aug 11, 2024
Open
@0xbaha 0xbaha mentioned this pull request Aug 31, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this pull request Aug 31, 2024
Open
This was referenced Aug 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
@0xbaha 0xbaha mentioned this pull request Sep 8, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this pull request Sep 8, 2024
Open
This was referenced Sep 8, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 15, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fb55 fb55 fb55 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5saviahv @fb55