Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attr): Fix handling of undefined as value #1582

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conversation

fb55
Copy link
Member

@fb55 fb55 commented Dec 22, 2020

Fixes #554

This makes cheerio behave like jQuery with these values.

Tests were part of the issue above, contributed by @iwarren.

Fixes #554

This makes cheerio behave like jQuery with these values.

Tests were part of the issue above, contributed by @iwarren.

Co-Authored-By: Ian Warren <warreia@gmail.com>
@fb55 fb55 merged commit 3b35ae4 into main Dec 22, 2020
@fb55 fb55 deleted the fix/attr-undefined branch December 22, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

.attr with value of undefined returns undefined
1 participant