Correct rendering of root node #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change normalizes rendering between trees generated by parse5 and htmlparser2. Consistent rendering of the "root" node is especially important given that `cheerio.render($.root())` will be the recommended pattern for rendering entire documents in Cheerio version 1.0.
fb55
approved these changes
May 13, 2019
|
Sure thing |
curbengh
added a commit
to curbengh/hexo-nofollow
that referenced
this pull request
Aug 19, 2019
curbengh
added a commit
to curbengh/hexo-nofollow
that referenced
this pull request
Aug 19, 2019
4 tasks
fb55
pushed a commit
that referenced
this pull request
Sep 10, 2020
This change normalizes rendering between trees generated by parse5 and htmlparser2. Consistent rendering of the "root" node is especially important given that `cheerio.render($.root())` will be the recommended pattern for rendering entire documents in Cheerio version 1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change normalizes rendering between trees generated by parse5 and
htmlparser2. Consistent rendering of the "root" node is especially
important given that
cheerio.render($.root())will be the recommendedpattern for rendering entire documents in Cheerio version 1.0.