-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update openapi with GET /scenario-iterations/{iterationId}/vali… #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vivien-marble
force-pushed
the
vivien/openapi-validate-scenario
branch
from
August 21, 2023 09:53
4d44299
to
c701003
Compare
Vivien-marble
force-pushed
the
vivien/openapi-validate-scenario
branch
from
August 21, 2023 10:06
c701003
to
42be5dd
Compare
Pascal-Delange
approved these changes
Aug 21, 2023
Vivien-marble
force-pushed
the
vivien/openapi-validate-scenario
branch
2 times, most recently
from
August 21, 2023 12:12
d264f92
to
a5d8737
Compare
balzdur
approved these changes
Aug 21, 2023
...app-builder/src/routes/__builder/scenarios/$scenarioId/i/$iterationId/edit.rules.$ruleId.tsx
Outdated
Show resolved
Hide resolved
Vivien-marble
force-pushed
the
vivien/openapi-validate-scenario
branch
2 times, most recently
from
August 21, 2023 14:44
77ad14d
to
fb80b83
Compare
balzdur
approved these changes
Aug 21, 2023
Pascal-Delange
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
...app-builder/src/routes/__builder/scenarios/$scenarioId/i/$iterationId/edit.rules.$ruleId.tsx
Outdated
Show resolved
Hide resolved
balzdur
force-pushed
the
vivien/openapi-validate-scenario
branch
from
August 24, 2023 13:59
b1530f4
to
9d0388c
Compare
balzdur
force-pushed
the
vivien/openapi-validate-scenario
branch
from
August 25, 2023 08:53
d7b2ff8
to
84b30ed
Compare
balzdur
force-pushed
the
vivien/openapi-validate-scenario
branch
from
August 25, 2023 09:02
84b30ed
to
4a571c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update open api to reflect that scenario validation is:
removed from
PATCH /scenario-iterations/{iteration-id}
removed from
PATCH /scenario-iterations-rule/{rule-id}
added to
GET /scenario-iterations/{iterationId}/validation
Linear display-validation-errors-in-the-builder
Corresponding backend PR