Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update openapi with GET /scenario-iterations/{iterationId}/vali… #77

Merged
merged 11 commits into from
Aug 25, 2023

Conversation

Vivien-marble
Copy link
Contributor

@Vivien-marble Vivien-marble commented Aug 21, 2023

Update open api to reflect that scenario validation is:

  • removed from PATCH /scenario-iterations/{iteration-id}

  • removed from PATCH /scenario-iterations-rule/{rule-id}

  • added to GET /scenario-iterations/{iterationId}/validation

Linear display-validation-errors-in-the-builder

Corresponding backend PR

@Vivien-marble Vivien-marble force-pushed the vivien/openapi-validate-scenario branch from 4d44299 to c701003 Compare August 21, 2023 09:53
@Vivien-marble Vivien-marble marked this pull request as draft August 21, 2023 09:59
@Vivien-marble Vivien-marble force-pushed the vivien/openapi-validate-scenario branch from c701003 to 42be5dd Compare August 21, 2023 10:06
@Vivien-marble Vivien-marble force-pushed the vivien/openapi-validate-scenario branch 2 times, most recently from d264f92 to a5d8737 Compare August 21, 2023 12:12
@Vivien-marble Vivien-marble force-pushed the vivien/openapi-validate-scenario branch 2 times, most recently from 77ad14d to fb80b83 Compare August 21, 2023 14:44
@Vivien-marble Vivien-marble marked this pull request as ready for review August 21, 2023 16:40
Copy link
Contributor

@Pascal-Delange Pascal-Delange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@balzdur balzdur force-pushed the vivien/openapi-validate-scenario branch from b1530f4 to 9d0388c Compare August 24, 2023 13:59
@balzdur balzdur force-pushed the vivien/openapi-validate-scenario branch from d7b2ff8 to 84b30ed Compare August 25, 2023 08:53
@balzdur balzdur enabled auto-merge August 25, 2023 08:53
@balzdur balzdur force-pushed the vivien/openapi-validate-scenario branch from 84b30ed to 4a571c7 Compare August 25, 2023 09:02
@balzdur balzdur merged commit bfee3d9 into main Aug 25, 2023
1 check passed
@balzdur balzdur deleted the vivien/openapi-validate-scenario branch August 25, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants