Allow user to create, iterate and publish/unpublish a scenario #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks about right to me so far ! 👍
On thing we should do: you should borrow from @zoeKD 's PR to display the relevant buttons only when they should be available. (well, you have to go through a rebase of master anyway because Zoe's changes created quite a few conflicts in your PR)
| i18n: ['scenarios', 'navigation', 'common'] satisfies Namespace, | ||
| }; | ||
|
|
||
| const createListFormSchema = z.object({ |
There was a problem hiding this comment.
createScenarioFormSchema?
Create button to delete rule Make publish work Edit rule information
Allow moving around different iteration Clean some code run prettier
…ditor If draft exist change modal to give choice to switch to it or override it for creating draft Rename Score to Score modifier in rule Add min max value from -1000 to 1000 to score modifier in rule and display error for it
Roukii
force-pushed
the
alexandre/scenario-add-all-buttons
branch
from
136e77f
to
b683f3f
Compare
Co-authored-by: Pascal <128643171+Pascal-Delange@users.noreply.github.com>
change translation for when there is no rule
Pascal-Delange
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality added:
Miscellaneous: