Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfercheck): fix currency formatting #517

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

balzdur
Copy link
Collaborator

@balzdur balzdur commented Aug 5, 2024

Introduce a currency formatter.

In short:

  • add currency definition
  • use a dedicated library to handle decimal conversion (and/or future manipulation)

NB: the library is tree-shaken, so we only use a portion of it in our bundle. Currencies definition are only use server side, in the adapter (so the full definition is not shipped to the client)

output

The huge amount used in the video is an example of "max int limitation" issue in JS (still, this is definitively not something we should face any time soon based on our current scope). More info in the dedicated Notion design doc

@balzdur balzdur force-pushed the thomas/fix-transfercheck-amount branch from baecd2c to 3d83503 Compare August 5, 2024 14:04
@balzdur balzdur force-pushed the thomas/fix-transfercheck-amount branch from 3d83503 to a8125e6 Compare August 5, 2024 15:10
@balzdur balzdur merged commit 3978c1e into main Aug 6, 2024
3 checks passed
@balzdur balzdur deleted the thomas/fix-transfercheck-amount branch August 6, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants