Thomas/update conform #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balzdur
force-pushed
the
thomas/update-conform
branch
from
8c0083f
to
721c58f
Compare
Pascal-Delange
approved these changes
Jul 22, 2024
| "@vitest/coverage-v8": "^1.6.0", | ||
| "@vitest/ui": "1.6.0", | ||
| "prettier": "^3.3.2", | ||
| "@vitest/coverage-v8": "^2.0.3", |
There was a problem hiding this comment.
just to be sure and since those are major version changes, can you please double check the license type didn't change ?
| "@conform-to/dom": "^0.9.1", | ||
| "@conform-to/react": "^0.9.1", | ||
| "@conform-to/zod": "^0.9.1", | ||
| "@conform-to/dom": "^1.1.5", |
There was a problem hiding this comment.
I think the comment is not at the good position
| const name = useFieldName(); | ||
| const [meta] = useField<boolean>(name); | ||
|
|
||
| const control = unstable_useControl(meta); |
There was a problem hiding this comment.
sanity check: what should I make of "unstable_" ?
There was a problem hiding this comment.
Nothing 🤷🏽
This is a common convention for pkg mainteners to tell the public API is unstable and may be changed with breaking changes in the future; still the hook is introduced for more than 4 months now, w\ any changes. This was created in order to fix issues with the initial attempt of handling form custom inputs useInputControl.
More info here
balzdur
force-pushed
the
thomas/update-conform
branch
from
721c58f
to
d7705a4
Compare
balzdur
force-pushed
the
thomas/update-conform
branch
from
d7705a4
to
028c727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally did it, it was painfull but here we are !
In short: I updated to the last major of
conformr(= the form lib I want to use in the app, that should replace entirelyreact-hook-formin the end).NB: I tested all the forms to make sure no regressions are introduced + improved existing one (ex: when creating a scenario, error messages are displayed now).
Another UX improvment, when an error occure at first submit, each fields is validated "on change", so no more "dangling" error messages above fields (when the validation can be done frontend side, of course).
I honnestly doubt you can review it... reading some forms update should be a good way to catch the main changes :
FormProviderto access the state in order to give progressive enhancementGlobally the same interface we already used (forFormField,FormInput`....)