chore(deps): update to vite #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal-Delange
approved these changes
Jul 4, 2024
balzdur
force-pushed
the
thomas/update-remix
branch
from
91fe26e
to
a8cf077
Compare
Pascal-Delange
added a commit
that referenced
this pull request
Jul 4, 2024
This reverts commit f4a625e.
Pascal-Delange
added a commit
that referenced
this pull request
Jul 4, 2024
This reverts commit f4a625e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impactfull PR: at the end of 2023, Remix moved to Vite as their main long term bundler solution.
Since 3/4 months, the Vite integration is considered stable and it's now time to move in. Since bugs due to a bundler swap are nasty to debug, I prefer to make this only change in "Remix future flags update" (we will see if no regression are met and I'll do other changes in the future).
For now, I tested :
To give some clue on what could go wrong : issue in bundling :
NB: since Vite do a lot of stuff lazylly (to start... "vite") the first time you start the app locally in dev mode may be slow/buggy (during some navigation I experienced small errors that fix after ViteJS optimized locally some deps). When the "optimize" phase is completed, deps should be cached locally and everything should work properly