refactor(editor): remove old editor #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balzdur
force-pushed
the
thomas/remove-old-editor
branch
from
dd339f6
to
88a9a7c
Compare
balzdur
commented
Sep 4, 2023
balzdur
commented
Sep 4, 2023
Comment on lines
+269
to
+304
| function updateValidation({ | ||
| editorNodeViewModel, | ||
| validation, | ||
| }: { | ||
| editorNodeViewModel: EditorNodeViewModel; | ||
| validation: NodeEvaluation; | ||
| }): EditorNodeViewModel { | ||
| // Ensure validation is consistent with view model (due to children, namedChildren recursion) | ||
| if (!validation) { | ||
| throw new Error('validation is required'); | ||
| } | ||
|
|
||
| return { | ||
| ...editorNodeViewModel, | ||
| validation: adaptValidation(validation), | ||
| children: editorNodeViewModel.children.map((child, i) => | ||
| updateValidation({ | ||
| editorNodeViewModel: child, | ||
| validation: validation.children[i], | ||
| }) | ||
| ), | ||
| namedChildren: R.mapValues( | ||
| editorNodeViewModel.namedChildren, | ||
| (child, namedKey) => | ||
| updateValidation({ | ||
| editorNodeViewModel: child, | ||
| validation: validation.namedChildren[namedKey], | ||
| }) | ||
| ), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Will require some unit tests (wait for @Vivien-marble job on configuring vitest for the app-builder package)
Vivien-marble
approved these changes
Sep 5, 2023
Vivien-marble
approved these changes
Sep 5, 2023
balzdur
force-pushed
the
feature/refactor-builder
branch
from
7cdf697
to
83faaad
Compare
… are build by the editor
…ult ast are build by the editor
balzdur
force-pushed
the
thomas/remove-old-editor
branch
from
88a9a7c
to
b97ae79
Compare
balzdur
force-pushed
the
thomas/remove-old-editor
branch
from
b97ae79
to
278addd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the old editor in favour of the new one.