Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Allow passing undefined for chart options #11780

Merged
merged 1 commit into from
May 21, 2024

Conversation

jdufresne
Copy link
Contributor

When exactOptionalPropertyTypes, TypeScript distinguishes between the value undefined and the property not existing. See:

https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes

For Chart.js options, this difference is not important and either passing undefined or not including it have the same effect.

When exactOptionalPropertyTypes, TypeScript distinguishes between the
value undefined and the property not existing. See:

https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes

For Chart.js options, this difference is not important and either
passing undefined or not including it have the same effect.
@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label May 21, 2024
@LeeLenaleee LeeLenaleee added this to the 4.5.0 milestone May 21, 2024
@etimberg etimberg merged commit 228a485 into chartjs:master May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants