Remove old feature switches #86
Conversation
|
Hi @ianwjhalliday, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
|
||
| typeHandler->Convert(objectConstructor, mode, propertyCount); | ||
| typeHandler->Convert(objectConstructor, mode, 20); |
There was a problem hiding this comment.
Can we seize the opportunity to replace "20" with a meaningfully-named constant?
There was a problem hiding this comment.
I considered that but all these Initialize functions use unnamed constants, and when you look at the parameter name its obvious what the value is for. I decided it wasn't worth bothering with.
|
It would be nice to keep -ES6Promise, ES6Unscopables, ES6String and ES6Object switches. These API's are frequently overridden by various polyfill's. An easy way to disable these comes in handy for website reductions. |
|
@abchatra good catch. I'll update the PR to leave out those removals. |
| @@ -8,7 +8,7 @@ namespace Js | |||
| { | |||
| ObjectPrototypeObject::ObjectPrototypeObject(DynamicType* type) : DynamicObject(type) | |||
| { | |||
| __proto__Enabled = GetScriptContext()->GetConfig()->Is__proto__Enabled(); | |||
| __proto__Enabled = true; // TODO[ianhall]: Does this still apply if __proto__ is now always enabled? Check with JC | |||
There was a problem hiding this comment.
I wonder if we can now eliminate the flag altogether.
|
Any update here? |
ianwjhalliday
force-pushed
the
rmfeatureswitches
branch
from
6b21b26
to
73fb8a0
Compare
|
Any update here? |
ianwjhalliday
force-pushed
the
rmfeatureswitches
branch
3 times, most recently
from
0a2f9a8
to
e5ab1b8
Compare
Re issue chakra-core#6 Also add ThreadConfigFlagsList.h to the VS solution.
Re issue chakra-core#6 Also fixed up initialization of Array.prototype.values function.
After removal of the LetConst switch this predicate would only ever be true.
After removal of the LetConst switch this predicate is always true.
Was used when block scoping was disabled which we no longer support. Block scoping is now always enabled, so this catch scope behavior is dead.
Function no longer does anything given ES6 block scoping.
-TDZ feature switch was originally put in because temporal dead zones as a concept were not yet decided upon for ES6 back in the day. That ship has long since sailed now and TDZ is here to stay. Removing it.
ianwjhalliday
force-pushed
the
rmfeatureswitches
branch
from
e5ab1b8
to
620325c
Compare
|
@dotnet-bot test Windows x64_debug please |
Merge pull request #86 from ianwjhalliday:rmfeatureswitches Addresses #6. Though there are a few more switches remain that I believe would be good to remove. Removes the following switches: - `LetConst` - `Map` - `Set` - `WeakMap` - `ES6WeakSet` - `DefineGetterSetter` - `__proto__` - `ES6Iterators` - `ES6Lambda` - `ES6NumericLiteral` - `ES6StringTemplate` - `ES6Symbol` - `TDZ` With the removal of `-LetConst` a couple of predicates become always true and have been removed. They are: - `BindDeferredPidRefs()` - `IsBlockScopeEnabled()` Parser binding had specific logic to handle catch scopes in non-block scope mode to support legacy ES5 behavior. This has also been removed. Finally `Parser::CheckStrictModeFncDeclNotSourceElement()` no longer did anything so it has also been removed.
Addresses #6. Though there are a few more switches remain that I believe would be good to remove.
Removes the following switches:
LetConstMapSetWeakMapES6WeakSetDefineGetterSetter__proto__ES6IteratorsES6LambdaES6NumericLiteralES6StringTemplateES6SymbolTDZWith the removal of
-LetConsta couple of predicates become always true and have been removed. They are:BindDeferredPidRefs()IsBlockScopeEnabled()Parser binding had specific logic to handle catch scopes in non-block scope mode to support legacy ES5 behavior. This has also been removed.
Finally
Parser::CheckStrictModeFncDeclNotSourceElement()no longer did anything so it has also been removed.