Adding a new configuration to build binaries for code coverage analysis #17
Conversation
|
Hi @aneeshdk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
@digitalinfinity & @abchatra can you please review this? |
| @@ -22,20 +24,24 @@ param ( | |||
| ) | |||
|
|
|||
| $global:exitcode = 0 | |||
|
|
|||
| $global:flavPathStr = $flavor | |||
There was a problem hiding this comment.
Also I don't understand why noopt isn't just a normal flavor and requires this hacky looking special casing. Is it not possible to make noopt work like debug release and test so that this flavPathStr variable is unnecessary?
There was a problem hiding this comment.
Made it global because it is used in pre_post_util.ps1 too. Also the value can change inside other methods in the future. Noopt can be used with any flavor, so it does not exactly replace flavor string. Something like test_noopt or debug_noopt will be the more right format but I am keeping it this way for now to align with the infrastructure pieces.
aneeshdk
force-pushed
the
EnablingCodeCoverageBuild
branch
from
86085d8
to
34f4b92
Compare
Made codecoverage to treated similar to a flavor
aneeshdk
force-pushed
the
EnablingCodeCoverageBuild
branch
from
34f4b92
to
3b13275
Compare
|
👍 |
|
LGTM |
The build is enabled by setting the environment variable ENABLE_CODECOVERAGE. For code coveage, optimization is turned off and additional arguments are passed during linking to include more debug information.