Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
kfarnung committed Jul 11, 2017
1 parent 9487a17 commit 7f3565b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/Jsrt/Jsrt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1347,7 +1347,7 @@ CHAKRA_API JsGetExtensionAllowed(_In_ JsValueRef object, _Out_ bool *value)

VALIDATE_INCOMING_OBJECT(object, scriptContext);
PARAM_NOT_NULL(value);
*value = nullptr;
*value = false;

*value = Js::RecyclableObject::FromVar(object)->IsExtensible() != 0;

Expand Down Expand Up @@ -1473,7 +1473,7 @@ CHAKRA_API JsHasProperty(_In_ JsValueRef object, _In_ JsPropertyIdRef propertyId
VALIDATE_INCOMING_OBJECT(object, scriptContext);
VALIDATE_INCOMING_PROPERTYID(propertyId);
PARAM_NOT_NULL(hasProperty);
*hasProperty = nullptr;
*hasProperty = false;

*hasProperty = Js::JavascriptOperators::OP_HasProperty(object, ((Js::PropertyRecord *)propertyId)->GetPropertyId(), scriptContext) != 0;

Expand Down Expand Up @@ -1510,7 +1510,7 @@ CHAKRA_API JsDefineProperty(_In_ JsValueRef object, _In_ JsPropertyIdRef propert
VALIDATE_INCOMING_PROPERTYID(propertyId);
VALIDATE_INCOMING_OBJECT(propertyDescriptor, scriptContext);
PARAM_NOT_NULL(result);
*result = nullptr;
*result = false;

Js::PropertyDescriptor propertyDescriptorValue;
if (!Js::JavascriptOperators::ToPropertyDescriptor(propertyDescriptor, &propertyDescriptorValue, scriptContext))
Expand Down Expand Up @@ -4740,7 +4740,7 @@ CHAKRA_API JsHasOwnProperty(_In_ JsValueRef object, _In_ JsPropertyIdRef propert
VALIDATE_INCOMING_OBJECT(object, scriptContext);
VALIDATE_INCOMING_PROPERTYID(propertyId);
PARAM_NOT_NULL(hasOwnProperty);
*hasOwnProperty = nullptr;
*hasOwnProperty = false;

*hasOwnProperty = Js::JavascriptOperators::OP_HasOwnProperty(object, ((Js::PropertyRecord *)propertyId)->GetPropertyId(), scriptContext) != 0;

Expand Down

0 comments on commit 7f3565b

Please sign in to comment.