Skip to content

Commit

Permalink
2.0.1
Browse files Browse the repository at this point in the history
  • Loading branch information
keithamus committed Sep 26, 2023
1 parent f934b22 commit 27ad8ba
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,6 @@
},
"engines": {
"node": ">= 12"
}
},
"version": "2.0.1"
}

5 comments on commit 27ad8ba

@mmozcelik
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithamus this should have been released with a new major version, it fails our builds due to the previous commit about converting project to an ES module.

@keithamus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry yeah I thought that was an already released major in 2.0. I'll fix.

@keithamus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmozcelik I've published 2.0.2. Please let me know if that works for you.

@MeLlamoPablo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithamus please consider marking 2.0.1 deprecated in favor of 2.0.2. We upgraded to 2.0.1 to get rid of the security alert, but we should've upgraded to 2.0.2 instead. We didn't realize this broke parts of our code, and then debugging the issue was difficult.

A deprecation warning would make easier for devs who upgrade to 2.0.1 to know that they should use 2.0.2 instead.

@keithamus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's now marked as deprecated https://www.npmjs.com/package/get-func-name/v/2.0.1.

Please sign in to comment.