Fix Google Drive downloads #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
confirm=1trick to get direct downloads even for large files recently (like a week ago) stopped working. So instead of downloading the file, Google Drive will give us a warning page "File too large to scan for viruses. Download Anyway?". So our automatic model downloading for tests will download those warning pages instead of models.Luckily, this warning page is very simple. No JS. Just simple HTML forms. So I just parse the form and piece together the real download link. This seems to work without problems.
Why hasn't this been a problem in recent PRs? Since our CI uses a cache, we weren't affected by this problem right away. The next time the cache gets evicted, we would be in trouble though because most Google Drive downloads will fail.