Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development infra #2

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add development infra #2

merged 1 commit into from
Jun 18, 2024

Conversation

ch4mpy
Copy link
Owner

@ch4mpy ch4mpy commented Jun 18, 2024

Replace Feign with spring-addons-starter-rest & RestClient

Use MapStruct

Replace Feign with spring-addons-starter-rest & RestClient

Use MapStruct
Copy link

gitguardian bot commented Jun 18, 2024

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11739525 Triggered SMTP credentials 18224eb api/quiz-api/src/main/resources/application.yml View secret
11717886 Triggered Generic High Entropy Secret 18224eb quiz-realm.json View secret
11717886 Triggered Generic High Entropy Secret 18224eb keycloak/import/quiz-realm.json View secret
11717888 Triggered Generic High Entropy Secret 18224eb quiz-realm.json View secret
11717888 Triggered Generic High Entropy Secret 18224eb keycloak/import/quiz-realm.json View secret
11717889 Triggered Generic High Entropy Secret 18224eb keycloak/import/quiz-realm.json View secret
11717889 Triggered Generic High Entropy Secret 18224eb quiz-realm.json View secret
11717890 Triggered Generic High Entropy Secret 18224eb quiz-realm.json View secret
11717890 Triggered Generic High Entropy Secret 18224eb keycloak/import/quiz-realm.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ch4mpy ch4mpy merged commit 007bb86 into main Jun 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant